-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurable window modes #322
Added configurable window modes #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Welcome aboard!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
One more thing before I'm happy to merge this in.. Should the default window mode be |
for the final game |
Who ever is merging, squash it ^^ |
I reset all reviews to make sure we don't forget about the squash before we merge :) |
Squash required.
I can squash it! I was thinking of naming the commit |
|
Oof, that not what i meant to do with update branch.... :D anyway can you rebase and squash? |
4b9ab3a
to
317a7e7
Compare
317a7e7
to
d2e6d51
Compare
References issue #291
This commit adds a new TOML variable which changes the window mode to use on start-up.
The TOML configuration file uses strings to indicate which mode should be used
windowed
windowed-fullscreen
fullscreen
Ability to change window mode on start-up
Ability to change window mode during runtime(moved to Ability to change window mode during runtime #328)Feedback welcome of course