Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Commit

Permalink
Minor changes
Browse files Browse the repository at this point in the history
  • Loading branch information
crufter committed Oct 24, 2019
1 parent 04192bc commit 421e695
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/e2e/spinup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"net/http"
"os/exec"
"strings"
"syscall"
"testing"
"time"

Expand Down Expand Up @@ -123,8 +122,8 @@ func spinup(t testing.TB, ctx context.Context, cfg config) (chan error, error) {

go func() { done <- cmd.Wait() }()

// This makes sure we get an output even it the binaries never stop,
// like it was the case with a SIGTERM bug.
// Timeout makes sure we get an output even it the binaries never stop,
// like it was the case with a Windows SIGTERM bug.
timeout := time.After(5 * time.Second)

var doneErr error
Expand All @@ -145,7 +144,6 @@ func spinup(t testing.TB, ctx context.Context, cfg config) (chan error, error) {
return doneErr
}, func(error) {
cmd.Process.Kill()
cmd.Process.Signal(syscall.SIGTERM)
})
}

Expand Down

0 comments on commit 421e695

Please sign in to comment.