Use general approach for rendering in commonmark #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalnytskyi
force-pushed
the
commonmark/exec-pipe
branch
2 times, most recently
from
cbd799e to
46a523f
Compare
Instead of supporting graphviz and any other possible text-to-diagram providers directly, let's build a general approach instead where a user can specify whatever executable they want to pipe the content of the code block through it, and replace the whole node w/ its output. This drops direct graphviz support in favor of built-in 'exec' pipe.
ikalnytskyi
force-pushed
the
commonmark/exec-pipe
branch
from
46a523f to
9a5c7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of supporting graphviz and any other possible text-to-diagram providers directly, let's build a general approach instead where a user can specify whatever executable they want to pipe the content of the code block through it, and replace the whole node w/ its output.
This drops direct graphviz support in favor of built-in 'exec' pipe.