Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS selector name in test helper #236

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Update CSS selector name in test helper #236

merged 2 commits into from
Jun 12, 2024

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Jun 12, 2024

Background

ember-qunit@v5 had supported the CSS class selector .full-screen. In 6.0.0, the selector had been renamed to .ember-testing-container-full-screen.

Latest version: https://github.com/emberjs/ember-qunit/blob/v8.1.0/addon/src/test-container-styles.css#L33

@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label Jun 12, 2024
@ijlee2 ijlee2 force-pushed the update-reset-viewport branch from 9a55b11 to d537cd8 Compare June 12, 2024 06:36
@ijlee2 ijlee2 force-pushed the update-reset-viewport branch from d537cd8 to 1a1f13d Compare June 12, 2024 06:39
@ijlee2 ijlee2 marked this pull request as ready for review June 12, 2024 06:43
@ijlee2 ijlee2 merged commit 5abe585 into main Jun 12, 2024
30 checks passed
@ijlee2 ijlee2 deleted the update-reset-viewport branch June 12, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant