Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ember-lts-5.4 to ember-try scenarios #219

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Added ember-lts-5.4 to ember-try scenarios #219

merged 3 commits into from
Dec 20, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Dec 20, 2023

Background

On December 17, Ember v5.4 became an LTS version.

https://blog.emberjs.com/ember-released-5-5

@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label Dec 20, 2023
@@ -7,7 +7,7 @@ on:
pull_request:

env:
NODE_VERSION: 18.17
NODE_VERSION: 18
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in #211 (comment), I had to fix the Node version to 18.17 (i.e. disallow 18.18). Now, version 18.19 runs in CI.

@ijlee2 ijlee2 changed the title Updated CI Added ember-lts-5.4 to ember-try scenarios Dec 20, 2023
@ijlee2 ijlee2 marked this pull request as ready for review December 20, 2023 15:53
@ijlee2 ijlee2 merged commit 855d34c into main Dec 20, 2023
28 of 29 checks passed
@ijlee2 ijlee2 deleted the update-ci branch December 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant