Fix for DeX mouse offset on Android 13 #581
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
TL;DR : This is a fix for #301.
Problem
When used in Samsung DeX mode, the bVNC and aRDP apps have an offset between the Samsung DeX cursor and the actual remote cursor (of the viewed machine). I could also reproduce the issue on Opaque.
For some reason, I was only able to reproduce the issue on Android 13. Android 14 seems to be fine.
Change Log
getTitleBarHeight
inbVNC/src/main/java/com/iiordanov/bVNC/input/TouchInputHandlerGeneric.java
(as suggested in the issue, the offset seems to be the height of the window's toolbar)getY
in the same file to include the scaled height of the title bary
coordinate is computed inhandleMouseActions
in the same file to include the scaled height of the title barBehavior
Please let me know if anything is unclear or if you would like something changed in the PR.
Cheers !