Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DeX mouse offset on Android 13 #581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaelImhof
Copy link

Hi,

TL;DR : This is a fix for #301.

Problem

When used in Samsung DeX mode, the bVNC and aRDP apps have an offset between the Samsung DeX cursor and the actual remote cursor (of the viewed machine). I could also reproduce the issue on Opaque.

image

For some reason, I was only able to reproduce the issue on Android 13. Android 14 seems to be fine.

Change Log

  • Implemented getTitleBarHeight in bVNC/src/main/java/com/iiordanov/bVNC/input/TouchInputHandlerGeneric.java (as suggested in the issue, the offset seems to be the height of the window's toolbar)
  • Updated getY in the same file to include the scaled height of the title bar
  • Updated how the y coordinate is computed in handleMouseActions in the same file to include the scaled height of the title bar

Behavior

  • Fixes the issue on Android 13 (tested)
  • Does not cause any issue on Android 14 (tested)
  • Should work on older devices as well (expected, I do not have an older device but the conditions are in place in the code)

Please let me know if anything is unclear or if you would like something changed in the PR.

Cheers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant