Include the GAMS version of the transport tutorial #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Covers: * run__id, data, name, uniqueness of name together with run__id * Adapts tests since default order of columns changes
* Make Column generic enough for multiple parents * Introduce optimization.Parameter * Add tests for add_data * Enable remaining parameter tests (#86) * Enable remaining parameter tests * Include optimization parameter api layer (#89) * Bump several dependency versions * Let api/column handle both tables and parameters * Make api-layer tests pass * Include optimization parameter core layer (#90) * Enable parameter core layer and test it * Fix things after rebase * Ensure all intended changes survive the rebase * Adapt data validation function for parameters * Allow tests to pass again
* Exclude non-working one for now * Duplicate model file :(
|
This PR now includes exhaustive tests of the newly added code. The main thing I would like to improve for them is how paths are handled, but this will have to wait until we finalize a location for the gams/solve-related code. |
This was referenced Aug 26, 2024
* Exclude resulting files from version control * Adapt code to make tests pass * Copy required code temporarily until location is finalized
glatterf42
force-pushed
the
include/transport-tutorial-gams
branch
from
9bf74bc
to
3c3b60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the same as #101, but with GAMS/gamsapi instead of linopy.
This PR is based on top of that branch, too, and actually adds only five commits. Two of those are the content of #107, so won't need to remain in here, either.
Hence: When reviewing/looking at the code, please focus on the new files in
tutorial/transport/.Please note: there is no test yet, but the values resulting from running the tutorial are correct. I'll add tests soon.