Temporary PR for Emscripten #9407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ihhub look #ifdef __EMSCRIPTEN__
EM_ASM( FS.syncfs( err = > err && console.warn( "FS.syncfs() error:", err ) ) );
#endiflinter suggested you invalid js code: |
oleg-derevenetz
commented
Jan 3, 2025
src/engine/serialize.cpp
Outdated
|
|
||
| #ifdef __EMSCRIPTEN__ | ||
| // clang-format off | ||
| EM_ASM( FS.syncfs( err => err && console.warn( "FS.syncfs() error:", err ) ) ); |
There was a problem hiding this comment.
I suppose that this call is no-op if there is nothing to sync, but if it leads to performance issues (since now it is called every time when StreamFile instance is closed and/or destroyed), it will be possible to think about how to optimize it.
|
|
||
| { | ||
| // In accordance with the contract, the _mutex should NOT be acquired while calling the executeTask(). | ||
| MutexUnlocker unlocker( _mutex ); |
There was a problem hiding this comment.
I suppose that mutexes under Emscripten are "only for show", but it's better be safe than sorry, so we need to unlock the mutex if it is promised by the contract.
Merged
oleg-derevenetz
force-pushed
the
emscripten-tmp
branch
from
50bec98 to
214fe9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9406