Improvements to Supplemental Read navigation and display #1412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major rework of the previous alignment dialog popup to make it interactive and clearer. Use it to navigate between reads in a supplemetnary alignment group.
Click to move to the selected read.
Shift + Click to add it as a split screen.
When jumping to a selected read/mate the selected reads will be now be sorted to the top.
@jrobinso There's currently a nondeterministic bug here, sometimes the sorting crashes with an NPE because the interval isn't loaded. I'm misunderstanding something about the loading code. It would be easy to fix it so it doesn't blow up by checking the interval for null, but then we'd just have the problem that it sometimes isn't putting the selected reads at the top mysteriously. I left it to blow up so that it's obvious when it happens so we can notice / fix it. I'm a bit puzzled by it
Renamed several classes and moved them to the ui/supdiagram package Refactoring some methods around Frame creation, this could still be improved.