OF-2921: Async closure partial revert #2660
Merged
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
OF-2921_Async-closure-partial-revert
branch
from
7ac55ac to
18783c1
Compare
Routing the unavailable presence that's sent out when a session closes cannot be made asynchronous. If the 'next step' is done prior to the routing of unavailable presence having completed, the session seems to be (partially) re-added. This causes an invalid state: the routing table no longer has the session, but caches such as the Routing Users Cache does. This incorrect behavior was introduced by a fix for OF-2921: igniterealtime@b98a83d It was already partially reverted by igniterealtime@7aca93f This commit reverts the remainder.
guusdk
force-pushed
the
OF-2921_Async-closure-partial-revert
branch
from
18783c1 to
edf1570
Compare
akrherz
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts some of the changes introduced to prevent a deadlock (OF-2921).
Routing the unavailable presence that's sent out when a session closes cannot be made asynchronous. If the 'next step' is done prior to the routing of unavailable presence having completed, the session seems to be (partially) re-added. This causes an invalid state: the routing table no longer has the session, but caches such as the Routing Users Cache does.
This incorrect behavior was introduced by a fix for OF-2921: b98a83d
It was already partially reverted by 7aca93f
The first commit in this PR reverts the remainder.