feat: make endpoint to create ratings #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekashok1221
requested changes
Oct 21, 2023
vivekashok1221
requested changes
Oct 31, 2023
| "update": {"value": rating.rating}, | ||
| }, | ||
| ) | ||
| except PrismaError as e: |
There was a problem hiding this comment.
We should return a special error message for when the post ID is incorrect (currently we return a 500).
There was a problem hiding this comment.
Although the frontend will probably handle supplying the correct post_id, it would still be nice to have a proper response for when things might go wrong.
vivekashok1221
requested changes
Mar 20, 2024
| """Get full details of a specific post.""" | ||
| post = await Post.prisma().find_first( | ||
| where={"id": id, "deleted": False}, include={"tags": True, "media": True, "author": True} | ||
| where={"id": post_id, "deleted": False}, | ||
| include={"tags": True, "media": True, "author": True}, | ||
| ) | ||
| if not post: | ||
| raise HTTPException(404, "Post not found") |
There was a problem hiding this comment.
id needs to be changed to post_id on line 111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.