brands

[shadowgaming-backup]

Resolves #86

[shadowgaming-backup]

The brands are from font awesome

[shadowgaming-backup]

the bash script is does not give any output, should i creates folders inside brands to show where i got it from

[shadowgaming-backup]

have not still used inkscape

[mdSlash]

Awesome, thanks for your effort! There’s just a small modification needed: please capitalize brand to Brands and move the .svg files to the svgs directory inside Brands.

[mdSlash]

the bash script is does not give any output, should i creates folders inside brands to show where i got it from

If there is no output, it means all the icons are solid and do not need to be converted.

[mdSlash]

have not still used inkscape
Yes, cause the icons are solid.

[shadowgaming-backup]

have not still used inkscape
Yes, cause the icons are solid.

OK, should I create a font awesome folder and pass all svgs files to there

[shadowgaming-backup]

I will make/find a script that it will prevent duplication,
Mostly will need to do a manual review to check

[mdSlash]

The Brand Pack should have a single folder called "svgs" with all the icons inside, just like the structure of the other packs. It might get a bit tricky because there are many icons with the same name and others with different names but similar designs. So, we’ll need to manually review and sort them out.

If you find icons with the same name but different designs, add a number to the end of the file name to differentiate them. For example, if the first one x.svg the second one x-1.svg the third one x-2.svg and so on.

Sorry for the lack of information and tools so far. I didn’t expect contributors to come on board so soon, so I’m still working on getting everything organized.

[mdSlash]

If you find it takes too long to sort things out, feel free to keep your current PR as it is for now.

[shadowgaming-backup]

The Brand Pack should have a single folder called "svgs" with all the icons inside, just like the structure of the other packs. It might get a bit tricky because there are many icons with the same name and others with different names but similar designs. So, we’ll need to manually review and sort them out.

Ok

If you find icons with the same name but different designs, add a number to the end of the file name to differentiate them. For example, if the first one x.svg the second one x-1.svg the third one x-2.svg and so on.

We can split the work
When you are free you can check and when you stop make sure to reply where you stop so we do not review it twice

Sorry for the lack of information and tools so far. I didn’t expect contributors to come on board so soon, so I’m still working on getting everything organized.

No problem, I even am not actively working on it. Can you make changes to it or should I invite you to the repo

[shadowgaming-backup]

If you are free you can help on review it depends on you

[shadowgaming-backup]

There is going to be a brands folder so shouldn't remove brands svg from others folders

[mdSlash]

I’m not currently working on it, but I will be soon. In the meantime, you can go ahead and put the icons in the "svgs" directory and rename "brands" to "Brands" before submitting your PR. I’ll continue from there once it’s in place. Thanks!

[shadowgaming-backup]

https://github.com/shadowgaming-backup/if/blob/main/packs/Brands/apple-pay.svg
https://github.com/shadowgaming-backup/if/blob/main/packs/Brands/cc-apple-pay.svg

There are the same logos but presented in a different way which do you prefer

[shadowgaming-backup]

I’m not currently working on it, but I will be soon. In the meantime, you can go ahead and put the icons in the "svgs" directory and rename "brands" to "Brands" before submitting your PR. I’ll continue from there once it’s in place. Thanks!

I have renamed to Brands
And added all svg inside packs/Brands folder

[mdSlash]

There are the same logos but presented in a different way which do you prefer

Both because the two designs have different styles

[mdSlash]

I have renamed to Brands And added all svg inside packs/Brands folder

Just like other packs, .svg files should go inside the PackName/svgs directory, not in the PackName/ directory

[shadowgaming-backup]

I have renamed to Brands And added all svg inside packs/Brands folder

Just like other packs, .svg files should go inside the PackName/svgs directory, not in the PackName/ directory

I am doing that, and I will be downloading other brands icon pack and i will run a script that checks for the same name