PAPI Pi4 Support #250
Open
PAPI Pi4 Support #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the A72 has the same events as the A57, this addition is a one-liner. This work is based on a patch by Stack Exchange user Bambo Wu, published in May 2021: https://raspberrypi.stackexchange.com/a/112396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request adds preset events for the Arm Cortex-A72, which is the processor used by the Raspberry Pi 4. This work is based on a patch by Stack Exchange user Bambo Wu, published in May 2021.
Known issues:
The
flops_validationtest fails because the Arm Cortex-A72 has no event for measuring normal floating point operations. The closest event isVFP_SPEC(INST_SPEC_EXEC_VFPin libpfm4) which seems to only measure the number of instructions in the vector floating point instruction set that have been speculatively executed. Because the Cortex-A57 and the Cortex-A15 all use this native event for thePAPI_FP_INSpreset event anyway, it seems like the best course to keep using it for the Cortex-A72 even though it does not count all floating point instructions.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests