Add Fortran-specific build for FFTE #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not an expert in CMake but this seems correct to me. |
cayrols
reviewed
Apr 7, 2022
| @@ -50,6 +50,10 @@ macro(fiber_add_mpi_test) | |||
| unset(_fiber_COMMAND) | |||
| endmacro() | |||
|
|
|||
| if (FIBER_ENABLE_FFTE) | |||
| link_directories(${CMAKE_Fortran_IMPLICIT_LINK_DIRECTORIES}) | |||
There was a problem hiding this comment.
Just one word about this implicit variable.
What is it for?
There was a problem hiding this comment.
For Gfortran, implicit library is -lgfortran. For IBM, it's -lxlf and so on. And they are usually hidden in strange place so I need LINK_DIRECTORIES added to tell linker where to find them.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for the explanation.
af-ayala
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added more generic support for Fortran-specific builds that will work across Fortran compiler vendors. It worked with Open MPI Gflortran and IBM Spectrum MPI XL Fotran. This is to address #13 and there is still need to figure C interface to Fortran code.