Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dark-light to v2 #2724

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Upgrade dark-light to v2 #2724

merged 4 commits into from
Jan 14, 2025

Conversation

Rudxain
Copy link
Contributor

@Rudxain Rudxain commented Jan 9, 2025


  • This is only a breaking change due to the version bump, the actual Iced-API is intact.
  • I haven't cargo checked, as the repo is too big to git clone (for me). I know I could download without the git log data, but I don't have much time now.
  • I formatted the code on the Rust playground

@Rudxain Rudxain marked this pull request as draft January 10, 2025 00:05
@Rudxain Rudxain changed the title Upgrade dark-light to 2.0 Upgrade dark-light to v2 Jan 10, 2025
@Rudxain Rudxain marked this pull request as ready for review January 10, 2025 00:09
@edwloef
Copy link
Contributor

edwloef commented Jan 10, 2025

cargo check, cargo fmt --all -- --check and the tour example run through fine, clippy complains about something but it's unrelated to this pr. This transitively updates zbus to v5 which is definitely nice to have.

Comment on lines 173 to 174
Ok(dark_light::Mode::Light) | Ok(dark_light::Mode::Unspecified) | Err(_) => {
Theme::Light
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ok(dark_light::Mode::Light) | Ok(dark_light::Mode::Unspecified) | Err(_) => {
Theme::Light
_ => Theme::Light,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would've made this change before even opening the PR, but I decided to preserve the verbosity of the original just-in-case there's a reason for the verbosity

@hecrj hecrj added this to the 0.14 milestone Jan 14, 2025
@hecrj hecrj added improvement An internal improvement shell styling labels Jan 14, 2025
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hecrj hecrj enabled auto-merge January 14, 2025 11:38
@hecrj hecrj merged commit 2879797 into iced-rs:master Jan 14, 2025
15 checks passed
@Rudxain Rudxain deleted the dl2 branch January 16, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An internal improvement shell styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants