-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dark-light
to v2
#2724
Upgrade dark-light
to v2
#2724
Conversation
|
core/src/theme.rs
Outdated
Ok(dark_light::Mode::Light) | Ok(dark_light::Mode::Unspecified) | Err(_) => { | ||
Theme::Light |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok(dark_light::Mode::Light) | Ok(dark_light::Mode::Unspecified) | Err(_) => { | |
Theme::Light | |
_ => Theme::Light, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would've made this change before even opening the PR, but I decided to preserve the verbosity of the original just-in-case there's a reason for the verbosity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cargo check
ed, as the repo is too big togit clone
(for me). I know I could download without thegit log
data, but I don't have much time now.