feat: add a window drag resize task #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuza
commented
Oct 16, 2024
| @@ -1112,7 +1112,7 @@ pub fn native_key_code( | |||
| } | |||
| } | |||
|
|
|||
| /// Converts some [`UserAttention`] into it's `winit` counterpart. | |||
| /// Converts some [`UserAttention`] into its `winit` counterpart. | |||
There was a problem hiding this comment.
This is technically out of scope, but I noticed this typo so I figured I'd fix it while I'm at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing a custom title bar, most things are straight forward: minimizing, maximizing, closing, dragging, and the context menu.
However, there is one small issue: resizing. Since you have to turn off decorations, the border also gets disabled, and there is no easy way to specifically enable that through winit ( afaik ).
This PR exposes
winit'sdrag_resize_windowto give an easier time to resize the window, which is especially useful for the case I mentioned above.Hopefully everything is up to standard!