Add missing update to the shared class cache search path #8
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLClassPath.getResource(String name, boolean check) was removed in 24 due to the security manager removal. The OpenJ9 patch to update the scc's search path was lost because of this change. Signed-off-by: Theresa Mammarella <[email protected]>
|
|
Yes. Sorry I didn't have a chance to open the related changes before the end of the day yesterday. |
|
Jenkins test sanity.functional alinux jdk24 |
|
Test (re-enabled via eclipse-openj9/openj9#20905) passed in https://openj9-jenkins.osuosl.org/job/Grinder/4063. |
keithc-ca
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLClassPath.getResource(String name, boolean check) was removed in 24
due to the security manager removal. The OpenJ9 patch to updated the
scc's search path was lost because of this change.
Copied from Java 23: https://github.com/ibmruntimes/openj9-openjdk-jdk23/blob/openj9/src/java.base/share/classes/jdk/internal/loader/URLClassPath.java#L420-L422
Related to eclipse-openj9/openj9#20702
Port to next: ibmruntimes/openj9-openjdk-jdk#914