fix: selectionchange should triggered by the user event rather than api event #4030
electroluxcodeAnnotations
10 errors, 6 warnings, and 1 notice
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css:
playwright/integration/examples/code-highlighting.test.ts#L35
1) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css:
playwright/integration/examples/code-highlighting.test.ts#L35
1) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css:
playwright/integration/examples/code-highlighting.test.ts#L35
1) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css:
playwright/integration/examples/code-highlighting.test.ts#L35
1) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css:
playwright/integration/examples/code-highlighting.test.ts#L35
1) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
Retry #4 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css:
playwright/integration/examples/code-highlighting.test.ts#L35
1) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
Retry #5 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html:
playwright/integration/examples/code-highlighting.test.ts#L35
2) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html:
playwright/integration/examples/code-highlighting.test.ts#L35
2) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html:
playwright/integration/examples/code-highlighting.test.ts#L35
2) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html:
playwright/integration/examples/code-highlighting.test.ts#L35
2) [chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.selectOption: Error: strict mode violation: getByTestId('language-select') resolved to 2 elements:
1) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// Add the initial valu' }).getByTestId('language-select')
2) <select class="css-rc8lf3" contenteditable="false" data-…>…</select> aka getByRole('textbox').locator('div').filter({ hasText: 'CSSHTMLJavaJavaScriptJSXMarkdownPHPPythonSQLTSXTypeScript// TypeScript users onl' }).getByTestId('language-select')
=========================== logs ===========================
waiting for getByTestId('language-select')
============================================================
33 | await page.locator('[data-slate-editor]').fill('') // clear editor
34 | await page.getByTestId('code-block-button').click() // convert first and the only one paragraph to code block
> 35 | await page.getByTestId('language-select').selectOption({ value: language }) // select the language option
| ^
36 |
37 | await page.keyboard.type(text) // type text
38 | }
at setText (/home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:35:45)
at /home/runner/work/slate/slate/playwright/integration/examples/code-highlighting.test.ts:14:7
|
|
lint:eslint:
packages/slate-react/src/components/editable.tsx#L1227
React Hook useCallback has a missing dependency: 'attributes.onClick'. Either include it or remove the dependency array
|
|
Slow Test:
[firefox] › integration/examples/mentions.test.ts#L1
[firefox] › integration/examples/mentions.test.ts took 2.3m
|
|
Slow Test:
[firefox] › integration/examples/hovering-toolbar.test.ts#L1
[firefox] › integration/examples/hovering-toolbar.test.ts took 2.2m
|
|
Slow Test:
[chromium] › integration/examples/hovering-toolbar.test.ts#L1
[chromium] › integration/examples/hovering-toolbar.test.ts took 2.0m
|
|
Slow Test:
[firefox] › integration/examples/code-highlighting.test.ts#L1
[firefox] › integration/examples/code-highlighting.test.ts took 1.0m
|
|
Slow Test:
[chromium] › integration/examples/code-highlighting.test.ts#L1
[chromium] › integration/examples/code-highlighting.test.ts took 41.0s
|
|
🎭 Playwright Run Summary
14 failed
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html
[chromium] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting jsx
[chromium] › integration/examples/hovering-toolbar.test.ts:8:7 › hovering toolbar example › hovering toolbar appears
[chromium] › integration/examples/hovering-toolbar.test.ts:21:7 › hovering toolbar example › hovering toolbar disappears
[chromium] › integration/examples/paste-html.test.ts:34:7 › paste html example › pasted code uses <code>
[firefox] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting css
[firefox] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting html
[firefox] › integration/examples/code-highlighting.test.ts:13:9 › code highlighting › code highlighting jsx
[firefox] › integration/examples/hovering-toolbar.test.ts:8:7 › hovering toolbar example › hovering toolbar appears
[firefox] › integration/examples/hovering-toolbar.test.ts:21:7 › hovering toolbar example › hovering toolbar disappears
[firefox] › integration/examples/mentions.test.ts:14:7 › mentions example › shows list of mentions
[firefox] › integration/examples/mentions.test.ts:22:7 › mentions example › inserts on enter from list
[firefox] › integration/examples/paste-html.test.ts:34:7 › paste html example › pasted code uses <code>
1 flaky
[firefox] › integration/examples/placeholder.test.ts:18:7 › placeholder example › renders editor tall enough to fit placeholder
2 skipped
61 passed (6.4m)
|