Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the triggers for the workflow run, added new tests, and added a status badge to README file. #44

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

bradwich
Copy link
Collaborator

@bradwich bradwich commented Sep 12, 2023

Please review the changes to the workflow file and advise of any changes needed.

Changed the triggers for workflow and added new tests on lines 24-27.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for parigot ready!

Name Link
🔨 Latest commit 07308be
🔍 Latest deploy log https://app.netlify.com/sites/parigot/deploys/6504b788bac7fb0008b027a2
😎 Deploy Preview https://deploy-preview-44--parigot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradwich bradwich changed the title Alt2 Changed the triggers for the workflow run Sep 12, 2023
@bradwich bradwich changed the title Changed the triggers for the workflow run Changed the triggers for the workflow run, added new tests, and added a status badge to README file. Sep 13, 2023
Copy link
Owner

@iansmith iansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about the yaml file.

@@ -1,3 +1,4 @@
[![Tests and Build](https://github.com/iansmith/parigot/actions/workflows/automake.yaml/badge.svg?branch=alt2)](https://github.com/iansmith/parigot/actions/workflows/automake.yaml) ![Go](https://img.shields.io/badge/go-%2300ADD8.svg?style=for-the-badge&logo=go&logoColor=white)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

test.yaml Outdated
branches:
- 'master/**'
run:
go run ci/main.go
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code actually in use? Can it be deleted?

Copy link
Owner

@iansmith iansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants