-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the triggers for the workflow run, added new tests, and added a status badge to README file. #44
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for parigot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment about the yaml file.
@@ -1,3 +1,4 @@ | |||
[![Tests and Build](https://github.com/iansmith/parigot/actions/workflows/automake.yaml/badge.svg?branch=alt2)](https://github.com/iansmith/parigot/actions/workflows/automake.yaml) ![Go](https://img.shields.io/badge/go-%2300ADD8.svg?style=for-the-badge&logo=go&logoColor=white) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
test.yaml
Outdated
branches: | ||
- 'master/**' | ||
run: | ||
go run ci/main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code actually in use? Can it be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please review the changes to the workflow file and advise of any changes needed.
Changed the triggers for workflow and added new tests on lines 24-27.