Switch to using Symbol.dispose

[grigasp]

Follow Bill's example in iTwin/itwinjs-core#7309.

[changeset-bot]

🦋 Changeset detected

Latest commit: 6152756

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@itwin/presentation-hierarchies-react	Minor
@itwin/unified-selection	Minor
@itwin/presentation-hierarchies	Minor
@itwin/presentation-components	Minor
@itwin/presentation-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Unified selection benchmark

Benchmark suite	Current: 1d4dad0	Previous: 2fe0b8c	Deviation	Status
hilite 50k elements	1220.89 ms	1307.84 ms	-6.6484%	✅
hilite 50k elements (P95 of main thread blocks)	43 ms	52 ms	-17.3077%	✅
hilite 50k group elements	237.56 ms	244.35 ms	-2.7788%	✅
hilite 50k group elements (P95 of main thread blocks)	31 ms	31 ms	0%	🟰
hilite 1k subjects	46136.3 ms	45353.07 ms	1.7270%	🚨
hilite 1k subjects (P95 of main thread blocks)	29 ms	30 ms	-3.3333%	✅
hilite 50k subcategories	281.98 ms	279.54 ms	0.8729%	🚨
hilite 50k subcategories (P95 of main thread blocks)	33 ms	34 ms	-2.9412%	✅
hilite 50k functional 3D elements	27757.18 ms	28706.87 ms	-3.3082%	✅
hilite 50k functional 3D elements (P95 of main thread blocks)	42 ms	37 ms	13.5135%	🚨
hilite 50k functional 2D elements	6519.79 ms	6712.93 ms	-2.8771%	✅
hilite 50k functional 2D elements (P95 of main thread blocks)	32 ms	46 ms	-30.4348%	✅
compute selection for 50k elements	301.7 ms	326.58 ms	-7.6183%	✅
compute selection for 50k elements (P95 of main thread blocks)	31 ms	31 ms	0%	🟰
compute parent selection for 50k elements	342.1 ms	339.01 ms	0.9115%	🚨
compute parent selection for 50k elements (P95 of main thread blocks)	31 ms	31 ms	0%	🟰
compute top ancestor selection for 50k elements	575.55 ms	572.27 ms	0.5732%	🚨
compute top ancestor selection for 50k elements (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
compute category selection for 50k elements	88.19 ms	91.35 ms	-3.4592%	✅
compute category selection for 50k elements (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
compute model selection for 50k elements	70.48 ms	70.43 ms	0.0710%	🚨
compute model selection for 50k elements (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
compute functional selection for 50k 3D elements	405.06 ms	404.81 ms	0.0618%	🚨
compute functional selection for 50k 3D elements (P95 of main thread blocks)	31 ms	31 ms	0%	🟰
compute parent functional selection for 50k 3D elements	444.51 ms	448.31 ms	-0.8476%	✅
compute parent functional selection for 50k 3D elements (P95 of main thread blocks)	31 ms	31 ms	0%	🟰
compute top ancestor functional selection for 50k 3D elements	1186.29 ms	1239.5 ms	-4.2929%	✅
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
compute functional selection for 50k 2D elements	3074.21 ms	3240.47 ms	-5.1307%	✅
compute functional selection for 50k 2D elements (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
compute parent functional selection for 50k 2D elements	3133.2 ms	3231.68 ms	-3.0473%	✅
compute parent functional selection for 50k 2D elements (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
compute top ancestor functional selection for 50k 2D elements	3154.46 ms	3329.62 ms	-5.2607%	✅
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Hierarchies benchmark

Benchmark suite	Current: 1d4dad0	Previous: e0d3176	Deviation	Status
flat 50k elements list	4881.73 ms	4688.44 ms	4.1227%	🚨
flat 50k elements list (P95 of main thread blocks)	75 ms	72 ms	4.1667%	🚨
filtering filters with 50000 paths	10798.68 ms	10454.59 ms	3.2913%	🚨
filtering filters with 50000 paths (P95 of main thread blocks)	108 ms	118 ms	-8.4746%	✅
grouping by label	11082.56 ms	10923.74 ms	1.4539%	🚨
grouping by label (P95 of main thread blocks)	70 ms	64 ms	9.3750%	🚨
grouping by class	11265.17 ms	11139.59 ms	1.1273%	🚨
grouping by class (P95 of main thread blocks)	51 ms	48 ms	6.2500%	🚨
grouping by property	11772.47 ms	11786.15 ms	-0.1161%	✅
grouping by property (P95 of main thread blocks)	66 ms	62 ms	6.4516%	🚨
grouping by base class (10 classes)	8518.28 ms	8457.63 ms	0.7171%	🚨
grouping by base class (10 classes) (P95 of main thread blocks)	73 ms	65 ms	12.3077%	🚨
grouping by multiple attributes	29146.76 ms	29112.94 ms	0.1162%	🚨
grouping by multiple attributes (P95 of main thread blocks)	48 ms	58 ms	-17.2414%	✅
hide if no children required to finalize root, w/o children	53789.5 ms	54006.31 ms	-0.4015%	✅
hide if no children required to finalize root, w/o children (P95 of main thread blocks)	40 ms	40 ms	0%	🟰
hide if no children required to finalize root, w/ children	203.25 ms	194.71 ms	4.3860%	🚨
hide if no children required to finalize root, w/ children (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
models tree initial (Baytown)	45.25 ms	44.52 ms	1.6397%	🚨
models tree initial (Baytown) (P95 of main thread blocks)	0 ms	0 ms	NaN%	🚨
models tree full (Baytown)	8534.99 ms	9008.08 ms	-5.2518%	✅
models tree full (Baytown) (P95 of main thread blocks)	94 ms	92 ms	2.1739%	🚨
models tree creates initial filtered view for 50k target items	2473.39 ms	2416.98 ms	2.3339%	🚨
models tree creates initial filtered view for 50k target items (P95 of main thread blocks)	557 ms	384 ms	45.0521%	🚨

This comment was automatically generated by workflow using github-action-benchmark.