Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Maps prototype #7414

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Google Maps prototype #7414

wants to merge 1 commit into from

Conversation

mdastous-bentley
Copy link
Contributor

No description provided.

@mdastous-bentley
Copy link
Contributor Author

@calebmshafer

mdastous-bentley
mdastous-bentley commented Nov 21, 2024
View reviewed changes
test-apps/display-test-app/src/frontend/GoogleMaps.ts
url: `https://tile.googleapis.com/v1/2dtiles/{level}/{column}/{row}`,
// url: `https://tile.googleapis.com/v1/2dtiles/{level}/{column}/{row}?session=${session}&key=${key}`,
name: "GoogleMaps",
subLayers: (subLayerName !== undefined ? [{name: subLayerName, visible: true, title: sessionOptsStr}] : undefined),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hack alert :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pass the session options in the sublayer title.

@aruniverse
Copy link
Member

@mdastous-bentley

Can you list what is left to do here?
I know this is a huge wip but wondering what it will take to wrap this up

@mdastous-bentley
Copy link
Contributor Author

mdastous-bentley commented Dec 2, 2024 •
edited
Loading

@mdastous-bentley

Can you list what is left to do here? I know this is a huge wip but wondering what it will take to wrap this up

  1. We need to change the map-layers API to accept an "opaque" provider configuration object. That way, we could create a Google map session object and pass it to the underlying imagery provider. To achieve this in the current prototype, I pass a serialized object into a sub-layer title(this is obviously a hack). This new object should be comparable, so that two map-layers having different configuration objects are represented by two different tile trees.

  2. Take a decision about the BackgroundMapProvider API. Do we want to continue to offer this simplified way of enabling the background map, OR now rely on helper classes , such as the GoogleMap.ts, to assist user in creating a map-layer suitable for a background map.

  3. We need to clarify if our logo cards dialog is legally acceptable for Google Maps:
    image
    If I recall correctly, the Google maps logo needs to be always displayed on top of the map.

@aruniverse aruniverse mentioned this pull request Dec 2, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbastings bbastings Awaiting requested review from bbastings bbastings will be requested when the pull request is marked ready for review bbastings is a code owner

@aruniverse aruniverse Awaiting requested review from aruniverse aruniverse will be requested when the pull request is marked ready for review aruniverse is a code owner

@ben-polinsky ben-polinsky Awaiting requested review from ben-polinsky ben-polinsky will be requested when the pull request is marked ready for review ben-polinsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdastous-bentley @aruniverse