Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compile target to ES2023 and module to ES2022 #7387

Merged
merged 9 commits into from
Dec 23, 2024
Merged

Update compile target to ES2023 and module to ES2022 #7387

merged 9 commits into from
Dec 23, 2024

Conversation

GytisCepk
Copy link
Contributor

aruniverse
aruniverse approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but plz have someone who owns the ecschema metadata review those changes

@GytisCepk
Copy link
Contributor Author

@ColinKerr @christophermlawson @naveedkhan8067, please review.

@GytisCepk GytisCepk merged commit 54baa05 into master Dec 23, 2024
16 checks passed
@GytisCepk GytisCepk deleted the gytis/bump-compile-target-to-es2023 branch December 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse approved these changes

@christophermlawson christophermlawson christophermlawson approved these changes

@saskliutas saskliutas saskliutas approved these changes

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

@wgoehrig wgoehrig Awaiting requested review from wgoehrig wgoehrig is a code owner

@ColinKerr ColinKerr Awaiting requested review from ColinKerr ColinKerr is a code owner

@StefanApfel-Bentley StefanApfel-Bentley Awaiting requested review from StefanApfel-Bentley StefanApfel-Bentley is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GytisCepk @aruniverse @saskliutas @christophermlawson