-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vitest dependencies #7340
base: master
Are you sure you want to change the base?
Bump vitest dependencies #7340
Conversation
hl662
commented
Nov 8, 2024
•
edited
Loading
edited
- Consume 2.1.5 for vitest related dependencies
- All vitest deps follow the same version number, to avoid dependency mismatch warnings when running tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't rush catch this?
The mismatched dependencies were in the pnpm lockfile. Some were '2.1.1', while others were '2.1.0'. I guess rush doesn't catch mismatched deps that are in lockfiles |
setting back to draft for now, circling back to fix regression for vitest/browser at a later point |
Marked as active again - I had to update the setup file for core frontend to import the barrel file. Vitest now inlines setup files into test files , messing up dependency resolution in test files and reintroducing circular imports otherwise |
This pull request is now in conflicts. Could you fix it @hl662? 🙏 |
Pull request was converted to draft