-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support drawing the horizontal bar chart #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the positions of the tooltips
Add docs for building custom charts
zhusee2
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, we can only draw vertical bar charts. Since horizontal bar charts are particularly useful on mobile devices, it is desirable to have it supported.
This PR realize drawing the horizontal bar chart by analyzing the data types of the X and Y axis: if the data type of the x-axis is
quantitative
, it should draw a horizontal chart, and draw the bars from the y-axis instead (via passing down the propdrawFromXAxis={false}
).Additionally, to make the charts which have both positive and negative value on the
quantitative
axis more readable, it adds a gray auxiliary line at zero-value.Tasks: See
Support horizontal bar charts
&Display a horizontal line at zero if there are negative y values like c3
: List of TODO items #25Updated doc (Click
Chart
>Bar Chart
): https://ichef.github.io/transcharts/Changes
Screenshots
Horizontal chart
Original vertical chart => Transposed horizontal chart
Original vertical chart
Transposed horizontal chart
Displaying tooltips