fixes memoized benchmark error

i22-digitalagentur · Jul 26, 2022 · 80f1be6 · 80f1be6
1 parent 76a2e3d
commit 80f1be6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/worker_tools/benchmark.rb b/lib/worker_tools/benchmark.rb
@@ -6,14 +6,16 @@ module Benchmark
       attr_accessor :benchmark
 
       def with_wrapper_benchmark(&block)
+        benchmark_error = nil
+
         benchmark = ::Benchmark.measure do
           block.call
         rescue StandardError => e
-          @benchmark_error = e
+          benchmark_error = e
         end
 
         model.meta['duration'] = benchmark.real.round if model.respond_to?(:meta)
-        raise @benchmark_error if @benchmark_error
+        raise benchmark_error if benchmark_error
       end
     end
   end

diff --git a/test/worker_tools/benchmark_test.rb b/test/worker_tools/benchmark_test.rb
@@ -44,6 +44,14 @@ def @importer.run
 
       assert_raises(StandardError) { @importer.perform(@import) }
       expect(@importer.model.meta['duration'] >= 1).must_equal true
+
+      # it does not raise on a second perform
+
+      def @importer.run
+        true
+      end
+
+      @importer.perform(@import)
     end
   end
 end