Implement remote desktop portal #308
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This PR implements the remote desktop portal with the wlr-virtual-pointer and virtual-keyboard protocol. This only works with 3l0w's hyprwm/Hyprland#7919 and hyprwm/hyprland-protocols#8
The RemoteDesktop portal makes client-side input-leap functional (as opposed to InputCapture, which is server-side).
also see 3l0w#1
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
There may be an issue with hyprwayland-scanner, which required me to patch virtual-keyboard-unstable-v1.cpp to create the virtual keyboard.
see hyprwm/hyprwayland-scanner#13 (comment)
Is it ready for merging, or does it need work?
it is a PR to a PR, it can only be merged once #268, hyprwm/Hyprland#7919 and hyprwm/hyprland-protocols#8, are merged.
also tell me if i did anything stupid