Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hyprpm reload -f unload & load all enabled plugins #8883

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented Dec 29, 2024

Describe your PR, what does it fix/add?

Implements #4731

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Is it ready for merging, or does it need work?

I've only tested it with one plugin enabled, will test a bit more first and then mark it as ready to review.

EDIT: tested with multiple plugins, only noticed one problem: the Hyprtrails plugin will crash Hyprland when unloading them:(hyprwm/hyprland-plugins#264). Not a problem with this PR, so ready to merge.

@zjeffer zjeffer marked this pull request as ready for review December 29, 2024 12:04
@zjeffer zjeffer force-pushed the feat/zjeffer/hyprpm-reload-force branch from 29af3e9 to 283d4ec Compare December 29, 2024 12:13
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as node-js tends to say
Using --force, I hope you know what you are doing.

so the hyprtrails issue can be ignored for now :)

@vaxerski vaxerski merged commit 5b37d53 into hyprwm:main Dec 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants