core: move parts of the animation system to hyprutils #8868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
config
managers
render
desktop
events
helpers
hyprerror
labels
PaideiaDilemma
force-pushed
the
hyprutils-animation
branch
from
4f571c1 to
263bfec
Compare
PaideiaDilemma
force-pushed
the
hyprutils-animation
branch
4 times, most recently
from
980873a to
937a36c
Compare
|
I've pushed hyprutils 0.3.1, cmakelists can be updated |
|
with HU 0.3.2 https://github.com/hyprwm/hyprutils/releases/tag/v0.3.2 I assume this should also move to the config tree before mergin? |
|
Yes sir, i think that would be best |
PaideiaDilemma
commented
Jan 2, 2025
Comment on lines
-1644
to
1620
| SAnimationPropertyConfig* CConfigManager::getAnimationPropertyConfig(const std::string& name) { | ||
| return &animationConfig[name]; | ||
| SP<SAnimationPropertyConfig> CConfigManager::getAnimationPropertyConfig(const std::string& name) { | ||
| return m_AnimationTree.getConfig(name); | ||
| } |
There was a problem hiding this comment.
Do we want to keep the existing interface, or make m_AnimationTree public and access it directly?
PaideiaDilemma
commented
Jan 2, 2025
PaideiaDilemma
force-pushed
the
hyprutils-animation
branch
from
33fbc53 to
137b7aa
Compare
Formatting needed because search-replace changes
PaideiaDilemma
force-pushed
the
hyprutils-animation
branch
from
137b7aa to
18bbbe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires hyprwm/hyprutils#27
Describe your PR, what does it fix/add?
Moves core components of the animation system to hyprutils. (In order to use it in hyprlock as well)
Introduces smart pointers for animated variables and animation properties.
Interface changes:
g_pAnimationManager->createAnimation. That function takes a value to always have AnimatedVaraibles explicitly initialized to a value.*m_vRealSize = Vector2D(42,42)and in a change fromav.setValuetoav->setValueav->setConfig.CAnimatedVaraiblenow has member functionsenabled,getBezierNameandgetStyleto get their config properties more easily.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Needs testing.
The damage handling was refactored a bit. Previously it damaged before and after a variable update inCAnimationManager::tick. I don't think that is needed and from what i tested it works the same as before.Possibly needs to be reverted to how it worked before, but the damage handling needs to be moved into functions, because we need to upcast first to get the context of animated variables.
Is it ready for merging, or does it need work?
Need some testing and review.