pass: mark crucial elements as undiscardable

hyprwm · Jan 1, 2025 · 9f3c9ac · 9f3c9ac
1 parent 7f177fa
commit 9f3c9ac
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 3 deletions.
diff --git a/src/render/pass/FramebufferElement.cpp b/src/render/pass/FramebufferElement.cpp
@@ -45,4 +45,8 @@ bool CFramebufferElement::needsLiveBlur() {
 
 bool CFramebufferElement::needsPrecomputeBlur() {
     return false;
-}
+}
+
+bool CFramebufferElement::undiscardable() {
+    return true;
+}
diff --git a/src/render/pass/FramebufferElement.hpp b/src/render/pass/FramebufferElement.hpp
@@ -14,6 +14,7 @@ class CFramebufferElement : public IPassElement {
     virtual void        draw(const CRegion& damage);
     virtual bool        needsLiveBlur();
     virtual bool        needsPrecomputeBlur();
+    virtual bool        undiscardable();
 
     virtual const char* passName() {
         return "CFramebufferElement";

diff --git a/src/render/pass/Pass.cpp b/src/render/pass/Pass.cpp
@@ -35,14 +35,14 @@ void CRenderPass::simplify() {
     CRegion    newDamage = damage.copy().intersect(CBox{{}, g_pHyprOpenGL->m_RenderData.pMonitor->vecTransformedSize});
     for (auto& el : m_vPassElements | std::views::reverse) {
 
-        if (newDamage.empty()) {
+        if (newDamage.empty() && !el->element->undiscardable()) {
             el->discard = true;
             continue;
         }
 
         el->elementDamage = newDamage;
         auto bb1          = el->element->boundingBox();
-        if (!bb1)
+        if (!bb1 || newDamage.empty())
             continue;
 
         auto bb = bb1->scale(g_pHyprOpenGL->m_RenderData.pMonitor->scale);

diff --git a/src/render/pass/PassElement.cpp b/src/render/pass/PassElement.cpp
@@ -15,3 +15,7 @@ bool IPassElement::disableSimplification() {
 void IPassElement::discard() {
     ;
 }
+
+bool IPassElement::undiscardable() {
+    return false;
+}
diff --git a/src/render/pass/PassElement.hpp b/src/render/pass/PassElement.hpp
@@ -12,6 +12,7 @@ class IPassElement {
     virtual bool                needsPrecomputeBlur()       = 0;
     virtual const char*         passName()                  = 0;
     virtual void                discard();
+    virtual bool                undiscardable();
     virtual std::optional<CBox> boundingBox();
     virtual CRegion             opaqueRegion();
     virtual bool                disableSimplification();

diff --git a/src/render/pass/PreBlurElement.cpp b/src/render/pass/PreBlurElement.cpp
@@ -18,3 +18,7 @@ bool CPreBlurElement::needsPrecomputeBlur() {
 bool CPreBlurElement::disableSimplification() {
     return true;
 }
+
+bool CPreBlurElement::undiscardable() {
+    return true;
+}
diff --git a/src/render/pass/PreBlurElement.hpp b/src/render/pass/PreBlurElement.hpp
@@ -10,6 +10,7 @@ class CPreBlurElement : public IPassElement {
     virtual bool        needsLiveBlur();
     virtual bool        needsPrecomputeBlur();
     virtual bool        disableSimplification();
+    virtual bool        undiscardable();
 
     virtual const char* passName() {
         return "CPreBlurElement";

diff --git a/src/render/pass/RendererHintsPassElement.cpp b/src/render/pass/RendererHintsPassElement.cpp
@@ -17,3 +17,7 @@ bool CRendererHintsPassElement::needsLiveBlur() {
 bool CRendererHintsPassElement::needsPrecomputeBlur() {
     return false;
 }
+
+bool CRendererHintsPassElement::undiscardable() {
+    return true;
+}
diff --git a/src/render/pass/RendererHintsPassElement.hpp b/src/render/pass/RendererHintsPassElement.hpp
@@ -15,6 +15,7 @@ class CRendererHintsPassElement : public IPassElement {
     virtual void        draw(const CRegion& damage);
     virtual bool        needsLiveBlur();
     virtual bool        needsPrecomputeBlur();
+    virtual bool        undiscardable();
 
     virtual const char* passName() {
         return "CRendererHintsPassElement";