xwayland: don't destroy server client

this potentially leaks, but avoids a UAF ref #6323
hyprwm · Jun 3, 2024 · 5517cc5 · 5517cc5
1 parent 0ac0f32
commit 5517cc5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/xwayland/Server.cpp b/src/xwayland/Server.cpp
@@ -262,8 +262,9 @@ void CXWaylandServer::die() {
     if (xwmFDs[1])
         close(xwmFDs[1]);
 
-    if (xwaylandClient)
-        wl_client_destroy(xwaylandClient);
+    // possible crash. Better to leak a bit.
+    //if (xwaylandClient)
+    //    wl_client_destroy(xwaylandClient);
 
     xwaylandClient = nullptr;
     waylandFDs     = {-1, -1};