Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow updating of an existing installation #9

Closed
wants to merge 1 commit into from

Conversation

bertm
Copy link
Contributor

@bertm bertm commented Jun 22, 2016

The installer cannot reliably be used to update an existing
installation, especially when dependencies have been updated: it does
not properly update wrapper.conf, breaking existing installations.

This exits the setup immediately when an existing Freenet installation
is found, displaying an error message to the user.

This requires the InnoSetup preprocessor (ISPP). I have tested this on Wine and it appears to work.

The installer cannot reliably be used to update an existing
installation, especially when dependencies have been updated: it does
not properly update wrapper.conf.

This exits the setup immediately when an existing Freenet installation
is found, displaying an error message to the user.
@ArneBab
Copy link
Contributor

ArneBab commented Jun 23, 2016

I think this error should only be shown, when the user tries to install into the same folder:

An existing Freenet installation is found in this folder. This installer cannot be used to update Freenet to a newer version. To update, enable Freenet's built-in automatic updates or run 'update.cmd' from the installation directory. To re-install, please uninstall Freenet first. To install another copy of Freenet, please choose another folder.

@bertm
Copy link
Contributor Author

bertm commented Jun 23, 2016

IMHO having multiple installations is an error for 99% of our users, and the other 1% will probably find their way around it.

Allowing multiple installations leads to more complex support scenarios, I'd prefer not having to deal with those.

@bertm
Copy link
Contributor Author

bertm commented Jun 23, 2016

That said, additional detection of an existing install based on a folder's contents (or just right out refusing to install into a non-empty directory) would not hurt.

@Thynix
Copy link
Contributor

Thynix commented Jul 16, 2017

Superseded by #11.

@Thynix Thynix closed this Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants