Fix obvious type error in guessMimetype #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change means that now calling mimetypes.guess_type is done with the argument type that mypy requires.
It seems that everywhere the node.guessMimetype is used, it is expected to return a str and not a tuple. Also, mimetypes.guess_type can handle the .tar.bz2 suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consider the fact that guessMimetype returns a tuple on some inputs and a str on other an obvious mistake. Where the result of guessMimetype is used, it looks like a tuple is not expected.
Also, I have verified that mimetypes.guess_type handles this case and returns application/x-tar (and bzip2) already in python 3.3.
This pull request depends on #40.