refactor: split parsing peers into multiple steps #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code nested too much error handling even though many parts are independent.
ArneBab
force-pushed
the
refactor--split-parsing-peers-into-multiple-simpler-steps
branch
from
5414fca to
13c71cb
Compare
Bombe
requested changes
Nov 18, 2024
src/freenet/node/PeerManager.java
Outdated
| // read the peers file | ||
| try { | ||
| while (true) { | ||
| peerEntries.add(new SimpleFieldSet(br, false, true)); |
There was a problem hiding this comment.
You’re mixing different kinds of whitespace here.
There was a problem hiding this comment.
resisting the urge to do a full file whitespace cleanup that would cause merging issues
| } | ||
| } | ||
|
|
||
| for (PeerNode pn : createdNodes) { |
There was a problem hiding this comment.
Even if this whole block is only copied, please add braces for all parts of if statements. 🙂
There was a problem hiding this comment.
Braces and spaces added (and some tabify) ☺
|
ready to be merged, as discussed with Bombe in FLIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code nested too much error handling even though many parts are independent.
This is a cleanup as sideeffect of trying to multi-thread the peer initialization. That multi-threading turned out to be unnecessary, but the cleanup is nice without it.