Remove hash generation to native big integer to reduce dependencies. #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneBab
changed the title
In the Guix build Hash.java was a blocker that had to be circumvented, because the i2p tools are not packaged. Since the two methods providing NativeBigInteger are unused, this PR removes them completely.
ArneBab
force-pushed
the
remove-native-big-integer-dependency-of-crypt-api
branch
from
793f6cc to
b66fcdc
Compare
|
Well, technically, this is public API but a grep over my Wait. There’s a test that you didn’t change and that now doesn’t compile, shouldn’t we have checks for that already or is that still WIP? |
|
This was only merged in 1495; I’m pretty sure no one is using it yet. But the test should not be broken; I missed that (need to add a gradle run to the workflows). |
|
@Bombe is this OK to merge? |
Bombe
approved these changes
Feb 29, 2024
|
Thank you for your review! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Guix build Hash.java was a blocker that had to be circumvented, because the i2p tools are not packaged.
Since the two methods providing NativeBigInteger are unused, this PR removes them completely.