-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer and more efficient healing #874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bombe
requested changes
Oct 29, 2023
Bombe
requested changes
Jan 28, 2024
This enables much cleaner testing by actually testing the public API. Thanks to Bombe for the review!
Bombe
requested changes
Jan 28, 2024
Bombe
requested changes
Jan 30, 2024
ArneBab
force-pushed
the
safer-healing
branch
from
January 30, 2024 19:29
52b2d77
to
202a8cd
Compare
Bombe
approved these changes
Jan 30, 2024
Merged — thanks a lot for your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the healing changes in 1497 there’s much more healing traffic for large files. But that brings new risks with it.
This PR tries to address them.