Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-48179: Revert NewClient api usage in configgrpc. #783

Open
wants to merge 1 commit into
base: 102+patches
Choose a base branch
from
Open

ENG-48179: Revert NewClient api usage in configgrpc. #783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/configgrpc/configgrpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
return nil, err
}
opts = append(opts, extraOpts...)
return grpc.NewClient(gcs.sanitizedEndpoint(), opts...)
return grpc.DialContext(ctx, gcs.sanitizedEndpoint(), opts...)

Check failure on line 233 in config/configgrpc/configgrpc.go

View workflow job for this annotation

GitHub Actions / test-coverage 

undefined: ctx

Check failure on line 233 in config/configgrpc/configgrpc.go

View workflow job for this annotation

GitHub Actions / unittest-matrix (ubuntu-latest, ~1.21.11) 

undefined: ctx

Check failure on line 233 in config/configgrpc/configgrpc.go

View workflow job for this annotation

GitHub Actions / unittest-matrix (ubuntu-latest, ~1.22) 

undefined: ctx

Check failure on line 233 in config/configgrpc/configgrpc.go

View workflow job for this annotation

GitHub Actions / windows-unittest 

undefined: ctx
}

func (gcs *ClientConfig) toDialOptions(host component.Host, settings component.TelemetrySettings) ([]grpc.DialOption, error) {
Expand Down
Loading