refactor: split the Header
trait into three traits
#110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Header
trait is nowNamed
,Decodable
andEncodable
.The goal of this change is to make it possible to implement
Encodable
for borrowed types. Under the existing code,
Header::decode()
requiresthat
Self
own its data. But it is a legitimate use to doHeader::encode()
on borrowed data. By separating the traits, we canimplement
Encodable
on borrowed types andEncodable
andDecodable
on owned types.
Signed-off-by: Nathaniel McCallum [email protected]