Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdaptiveGrid.AddEdge no longer delete edges in case where new edge partially overlaps old edges without intersections. #1070

Merged
merged 1 commit into from
Dec 5, 2023
Merged

AdaptiveGrid.AddEdge no longer delete edges in case where new edge partially overlaps old edges without intersections. #1070

merged 1 commit into from
Dec 5, 2023

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Dec 5, 2023 •
edited by andrewheumann
Loading

BACKGROUND:

  • When creating grid from a set of circulation objects I found that some edges disappear.
  • After investigation I found a bug in partial overlap of two edges: when one end is outside and one is inside.

DESCRIPTION:

  • Register missing intersection points in AddCutEdge.
  • It's not an issue if some of them will appear in the list several times since the list is later ordered and checked for duplicates.

TESTING:

  • Added AdaptiveGridAddCutWithOverlap to cover problematic case.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

@DmytroMuravskyi
AdaptiveGrid.AddEdge no longer delete edges in case where new edge …
6a58373 
…partially overlaps old edges without intersections.
wynged
wynged approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 1664079 into hypar-io:master Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmytroMuravskyi @wynged