Dynamic Function Result #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
commented
Dec 30, 2021
|
|
||
| public override bool TryInvokeMember(InvokeMemberBinder binder, object[] args, out object result) | ||
| { | ||
| if (binder.Name == "GetMetadata" && binder.CallInfo.ArgumentCount == 0) |
There was a problem hiding this comment.
With this code GetMetadata can be called on the results to get the current metadata. Not sure if we should expose it like this or just hide it.
var result = fn.Invoke<dynamic>();
result.GetMetadata();
result.MY_STRUCT.GetMetadata();
result.MY_TABLE.GetMetadata();
result.MY_TABLE[0].GetMetadata();
|
Good work, nice feature. Can we push and publish it? |
Merged
|
Rebased and ready for review. |
|
Thank you very much for your current version of dynamicrfc. Can the incoming parameters also be dynamically modified? @campersau |
|
guys: Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for invoking a function with a
dynamicreturn type. Values are read on demand and can not be accessed once the function gets disposed.Which means that this feature in its current state is not supported bySapPooledConnection.See #36 (comment) for more usage details.