Add scope check

hupe1980 · Jun 30, 2022 · 515652b · 515652b
1 parent 92529e2
commit 515652b
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 1 deletion.
diff --git a/API.md b/API.md
@@ -44,6 +44,7 @@ new plus_aws.ApplicationLoadBalancer(scope: Construct, id: string, props: Applic
 | --- | --- |
 | <code><a href="#cdktg.plus_aws.ApplicationLoadBalancer.toString">toString</a></code> | Returns a string representation of this construct. |
 | <code><a href="#cdktg.plus_aws.ApplicationLoadBalancer.communicatesWith">communicatesWith</a></code> | *No description.* |
+| <code><a href="#cdktg.plus_aws.ApplicationLoadBalancer.isInScope">isInScope</a></code> | *No description.* |
 | <code><a href="#cdktg.plus_aws.ApplicationLoadBalancer.isTrafficForwarding">isTrafficForwarding</a></code> | *No description.* |
 | <code><a href="#cdktg.plus_aws.ApplicationLoadBalancer.isWebApplication">isWebApplication</a></code> | *No description.* |
 | <code><a href="#cdktg.plus_aws.ApplicationLoadBalancer.isWebService">isWebService</a></code> | *No description.* |
@@ -84,6 +85,12 @@ public communicatesWith(id: string, target: TechnicalAsset, options: Communicati
 
 ---
 
+##### `isInScope` <a name="isInScope" id="cdktg.plus_aws.ApplicationLoadBalancer.isInScope"></a>
+
+```typescript
+public isInScope(): boolean
+```
+
 ##### `isTrafficForwarding` <a name="isTrafficForwarding" id="cdktg.plus_aws.ApplicationLoadBalancer.isTrafficForwarding"></a>
 
 ```typescript
@@ -471,6 +478,7 @@ new plus.Browser(scope: Construct, id: string, props: BrowserProps)
 | --- | --- |
 | <code><a href="#cdktg.plus.Browser.toString">toString</a></code> | Returns a string representation of this construct. |
 | <code><a href="#cdktg.plus.Browser.communicatesWith">communicatesWith</a></code> | *No description.* |
+| <code><a href="#cdktg.plus.Browser.isInScope">isInScope</a></code> | *No description.* |
 | <code><a href="#cdktg.plus.Browser.isTrafficForwarding">isTrafficForwarding</a></code> | *No description.* |
 | <code><a href="#cdktg.plus.Browser.isWebApplication">isWebApplication</a></code> | *No description.* |
 | <code><a href="#cdktg.plus.Browser.isWebService">isWebService</a></code> | *No description.* |
@@ -511,6 +519,12 @@ public communicatesWith(id: string, target: TechnicalAsset, options: Communicati
 
 ---
 
+##### `isInScope` <a name="isInScope" id="cdktg.plus.Browser.isInScope"></a>
+
+```typescript
+public isInScope(): boolean
+```
+
 ##### `isTrafficForwarding` <a name="isTrafficForwarding" id="cdktg.plus.Browser.isTrafficForwarding"></a>
 
 ```typescript
@@ -3019,6 +3033,7 @@ new TechnicalAsset(scope: Construct, id: string, props: TechnicalAssetProps)
 | --- | --- |
 | <code><a href="#cdktg.TechnicalAsset.toString">toString</a></code> | Returns a string representation of this construct. |
 | <code><a href="#cdktg.TechnicalAsset.communicatesWith">communicatesWith</a></code> | *No description.* |
+| <code><a href="#cdktg.TechnicalAsset.isInScope">isInScope</a></code> | *No description.* |
 | <code><a href="#cdktg.TechnicalAsset.isTrafficForwarding">isTrafficForwarding</a></code> | *No description.* |
 | <code><a href="#cdktg.TechnicalAsset.isWebApplication">isWebApplication</a></code> | *No description.* |
 | <code><a href="#cdktg.TechnicalAsset.isWebService">isWebService</a></code> | *No description.* |
@@ -3059,6 +3074,12 @@ public communicatesWith(id: string, target: TechnicalAsset, options: Communicati
 
 ---
 
+##### `isInScope` <a name="isInScope" id="cdktg.TechnicalAsset.isInScope"></a>
+
+```typescript
+public isInScope(): boolean
+```
+
 ##### `isTrafficForwarding` <a name="isTrafficForwarding" id="cdktg.TechnicalAsset.isTrafficForwarding"></a>
 
 ```typescript
@@ -3643,6 +3664,7 @@ new plus.Vault(scope: Construct, id: string, props: VaultProps)
 | --- | --- |
 | <code><a href="#cdktg.plus.Vault.toString">toString</a></code> | Returns a string representation of this construct. |
 | <code><a href="#cdktg.plus.Vault.communicatesWith">communicatesWith</a></code> | *No description.* |
+| <code><a href="#cdktg.plus.Vault.isInScope">isInScope</a></code> | *No description.* |
 | <code><a href="#cdktg.plus.Vault.isTrafficForwarding">isTrafficForwarding</a></code> | *No description.* |
 | <code><a href="#cdktg.plus.Vault.isWebApplication">isWebApplication</a></code> | *No description.* |
 | <code><a href="#cdktg.plus.Vault.isWebService">isWebService</a></code> | *No description.* |
@@ -3684,6 +3706,12 @@ public communicatesWith(id: string, target: TechnicalAsset, options: Communicati
 
 ---
 
+##### `isInScope` <a name="isInScope" id="cdktg.plus.Vault.isInScope"></a>
+
+```typescript
+public isInScope(): boolean
+```
+
 ##### `isTrafficForwarding` <a name="isTrafficForwarding" id="cdktg.plus.Vault.isTrafficForwarding"></a>
 
 ```typescript

diff --git a/src/risks.ts b/src/risks.ts
@@ -9,7 +9,9 @@ export class RiskAspect implements IAspect {
       // When a technical communication link does not send or receive any data assets, this is
       // an indicator for an unnecessary communication link (or for an incomplete model).
       if (!node.hasDataAssets()) {
-        Annotations.of(node).addWarning("Unnecessary Communication Link");
+        if (node.source.isInScope() || node.target.isInScope()) {
+          Annotations.of(node).addWarning("Unnecessary Communication Link");
+        }
       }
     }
   }

diff --git a/src/technical-asset.ts b/src/technical-asset.ts
@@ -127,6 +127,10 @@ export class TechnicalAsset extends Resource {
     ].includes(this.technology);
   }
 
+  public isInScope(): boolean {
+    return this.scope === Scope.inScope();
+  }
+
   public get highestIntegrity(): Integrity {
     let { integrity: highest } = this.ciaTriad;