Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make copy Button` visible in hex to channel inputs #950

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

carljohan
Copy link
Contributor

Copy buttons for HSL and RGB inputs was using the same color as background, making them invisible on https://www.shadcn-svelte.com/docs/theming.

  • updated CopyButton color and hover color for these instances
  • fix position of the CopyButtons
  • moved CopyButton below input to focus on input before focus on copy buttons when navigating using keyboard
  • remove tabindex from SVGs, which was causing double focus, both for button and SVGs when using navigating using keyboard.

Before

Screenshot-2024-03-25_11 25

After

Screenshot-2024-03-25_11 20 2

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: 10d7ef9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 25, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 10d7ef9

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit b5935d2 into huntabyte:main Mar 25, 2024
4 checks passed
@carljohan carljohan deleted the hex-copy-buttons-styling branch April 17, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants