Fix infinite loop and broken list rendering #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use of SvelteMarkdown I ran into a couple of weird issues:
Some lists would render wrong, by repeating their contents. e.g.
Others would crash with a message like:
Uncaught (in promise) RangeError: Maximum call stack size exceeded
when given a simple nested list.I've tracked both issues down to the Parser component where the recursive call would receive
...rest
instead of a more limited set of parameters like...parserRest
like it is done in other places in the component.I've adapted both of the list related calls to only pass on the more limited set of parameters and extended the tests to cover both types of nested lists and a mixed usage case.