Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten scope functionality should work with all the various corner cases #139

Merged
merged 2 commits into from
Nov 12, 2013

Conversation

agperson
Copy link
Contributor

@agperson agperson commented Nov 8, 2013

In the process, made changes to accomodate upcoming Cement 2.1 framework, 2.1.4-dev is now a dependency (hopefully temporarily). There are a lot of commands to test, its entirely possible I missed some conditions...

Various changes to accomodate Cement 2.1.  Using hooks for registry
loading and scope setting.  Fixing various scoping corner cases.
@robparrott
Copy link
Contributor

Woah!

On Fri, Nov 8, 2013 at 3:53 PM, Daniel Silverman [email protected]
wrote:

In the process, made changes to accomodate upcoming Cement 2.1 framework, 2.1.4-dev is now a dependency (hopefully temporarily). There are a lot of commands to test, its entirely possible I missed some conditions...
You can merge this Pull Request by running:
git pull https://github.com/huit/nepho feature/integrate-scope
Or you can view, comment on it, or merge it online at:
#139
-- Commit Summary --

  • Compatibility changes for Cement 2.1, global scope
    -- File Changes --
    M bin/nepho (5)
    M nepho/cli/init.py (3)
    M nepho/cli/base.py (44)
    M nepho/cli/blueprint.py (50)
    M nepho/cli/cloudlet.py (151)
    M nepho/cli/config.py (25)
    A nepho/cli/hooks.py (58)
    M nepho/cli/parameter.py (6)
    M nepho/cli/scope.py (53)
    M nepho/cli/stack.py (172)
    M nepho/core/common.py (2)
    M nepho/core/scenario.py (2)
    M nepho/providers/vagrant_provider.py (2)
    M setup.py (5)
    -- Patch Links --
    https://github.com/huit/nepho/pull/139.patch
    https://github.com/huit/nepho/pull/139.diff

@agperson agperson mentioned this pull request Nov 12, 2013
@hakamadare
Copy link
Contributor

yeah, this also looks like it solves (at least some of) the issues i'm tangling with in #115 - let's merge this sooner rather than later.

hakamadare added a commit that referenced this pull request Nov 12, 2013
Rewritten scope functionality should work with all the various corner cases
@hakamadare hakamadare merged commit 62a6d82 into master Nov 12, 2013
@hakamadare hakamadare deleted the feature/integrate-scope branch November 12, 2013 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants