Always run initialization code on browser start #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to work more consistently than the existing code in Firefox. Particularly, I could generally reproduce the extension not working if I quit and restart Firefox Dev multiple times. With this change, the extension loads on every browser startup, which seems like the desired behavior, and also should be reinitialized on upgrades.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix or at least help with #229, #182
This seems to work more consistently than the existing code in Firefox. Particularly, I could generally reproduce the extension not working (v2.0.0) if I simply quit and restart Firefox Dev multiple times.
With this change, the extension loads on every browser startup, which seems like the desired behavior, and also should be reinitialized on upgrades.
It might also be worth considering using this
background.scriptsmanifest instead of a custom page, but that would require changes tocore/manifest_v3.libsonnetand doesn't seem to be necessary for these changes to help.