Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transformers 4.43 #1968

Conversation

liammcinroy
Copy link

What does this PR do?

Allows transformers<4.44 as a dependency, since with the release of 4.43.0 (and 4.43.1 today), then optimum can't be installed with these versions.

Looking at the release notes of 4.43.0, I didn't see anything that would obviously break here (the biggest standout was huggingface/transformers#31696, but it seems that was handled in #1929 already). If there are any that stand out to anyone else, I'd be happy to take a look at the necessary fixes.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@fxmarty @IlyasMoutawwakil @echarlaix

based off of #1929

@IlyasMoutawwakil
Copy link
Member

see progress in #1971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants