Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object detection guide #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qubvel
Copy link
Member

@qubvel qubvel commented May 9, 2024

What does this PR do?

Update object detection guide notebook according to recent changes
huggingface/transformers#30683

Who can review?

@NielsRogge

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@qubvel
Copy link
Member Author

qubvel commented May 10, 2024

@NielsRogge can you please ping someone who can merge it?

@NielsRogge
Copy link
Contributor

Since this notebook is a copy of the object detection guide in Transformers (which already got an extensive review at huggingface/transformers#30683), I'll merge this one.

@NielsRogge
Copy link
Contributor

However @qubvel it's not in the right folder yet. We usually add them in the examples folder: https://github.com/huggingface/notebooks/tree/main/examples, although I feel like we should create subfolders there, however it breaks existing URLs.

@qubvel
Copy link
Member Author

qubvel commented May 10, 2024

Yeah, "open in colab" in the object-detection guide points to this notebook, I guess if we move it then it will be broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants