-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for generate_release_notes
Release API parameter.
#1746
Adds support for generate_release_notes
Release API parameter.
#1746
Conversation
}, | ||
"bodyPatterns" : [ | ||
{ | ||
"matchesJsonPath" : "$.[?(@.generate_release_notes == true)]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is where the newly added parameter is verified.
Pre-existing behavior of not passing generate_release_notes
when not set is validated in createSimpleRelease
test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
=========================================
Coverage 80.16% 80.16%
- Complexity 2301 2302 +1
=========================================
Files 217 217
Lines 6962 6964 +2
Branches 371 371
=========================================
+ Hits 5581 5583 +2
Misses 1150 1150
Partials 231 231 ☔ View full report in Codecov by Sentry. |
@bitwiseman thanks for fast turnaround reviewing it. Any chance to get this released in a foreseeable future? |
I can foresee that happening very soon. Next day or two. |
Released in 1.318. |
Description
Added support for
generate_release_notes
request body parameter for Releases GitHub API.This fixes #1745.
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: