[#1368] add flag control graceful invalid call service-center api #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verkulo456
reviewed
Aug 16, 2024
| serviceCombServiceRegistry.setStatus(serviceCombRegistration, status.toUpperCase()); | ||
| if (isOperationAllow(status)) { | ||
| serviceCombServiceRegistry.setStatus(serviceCombRegistration, status.toUpperCase()); | ||
| LOGGER.warn("servicecomb graceful update status success, status: " + status); |
There was a problem hiding this comment.
这个是正常级别的日志，不是warn类型的日志
verkulo456
reviewed
Aug 16, 2024
| } | ||
| LOGGER.warn("operation is not allowed, status: " + status + ", registration_enabled: " |
There was a problem hiding this comment.
用readiness修改状态实例状态为上线实现优雅上下线是推荐的方案之一，那这个操作就不是warn。改成info就可以了
verkulo456
reviewed
Aug 16, 2024
| LOGGER.warn("servicecomb graceful update status success, status: " + status); | ||
| return; | ||
| } | ||
| LOGGER.warn("operation is not allowed, status: " + status + ", instanceStatus: " |
verkulo456
reviewed
Aug 16, 2024
| } | ||
|
|
||
| private boolean isOperationAllow(String status) { | ||
| return (GovernanceProperties.GRASEFUL_STATUS_UPPER.equalsIgnoreCase(status) |
There was a problem hiding this comment.
圈复杂度有点搞，可以改成以下格式：
if （xxx）
return true
if （xxx）
return true
return false
verkulo456
approved these changes
Aug 16, 2024
chengyouling
added a commit
that referenced
this pull request
Aug 16, 2024
chengyouling
added a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servicecomb引擎场景：
1、由于spring加载bean是无序的，某些场景服务端口就绪了，但是微服务未注册，此时实例更新不成功。
2、上线脚本存在问题时，有可能多次请求更新实例状态为UP的情况，给服务端造成不必要的压力。
nacos场景：
上线脚本存在问题时，有可能多次请求更新实例状态为UP的情况，给服务端造成不必要的压力。