Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kotlin to 2.1.0, Gradle to v8.11.1, and remove all the app-conventions plugins #20

Merged
merged 12 commits into from
Dec 3, 2024

Conversation

ShreckYe
Copy link
Member

@ShreckYe ShreckYe commented Dec 2, 2024

The jvm-app-conventions plugins introduce "Could not parse POM" build errors since 2.0.20. See commit a490666 for more details.

These app-conventions plugins were introduced 2 and a half years ago in commit 80a6dbc, and turn out to be not necessary at all today, as the dependencies and congurations they add are not absolutely necessary for app projects.

…iJ IDEA without success, by removing the module-wide opt-in and bumping the Gradle wrapper

The Gradle error message when syncing in IntelliJ IDEA:

```text
Execution failed for task ':kotlin-common-gradle-plugins:configurePrecompiledScriptDependenciesResolver'.
> The value for property 'freeCompilerArgs' is final and cannot be changed any further.
```

This error doesn't occur when I run `publishToMavenLocal` or `check` from the command line. The commands work in the command line.

See gradle/gradle#22091 which could be related.
…-error-free-compiler-args-final-and-bump-gradle-wrapper-to-v8.11.2' into kotlin-2.1.0-and-above

Try resolving an error loading the Gradle project in IntelliJ IDEA 2024.3 and bump the Gradle Wrapper to v8.11.1

The bumped Gradle wrapper version is actually v8.11.1. "v8.11.2" in the branch name is incorrect.
…unnecessary as it turns out, and the `implementation(platform(kotlin("bom")))` line without a Kotlin version has introduced a "Could not parse POM" build error in projects dependent on a project with one of these plugins applied via Maven since Kotlin 2.0.20

See commit 1648b7e and commit dc9d1c8 for more details.
@ShreckYe ShreckYe marked this pull request as ready for review December 3, 2024 12:46
@ShreckYe ShreckYe self-assigned this Dec 3, 2024
@ShreckYe ShreckYe merged commit a013225 into main Dec 3, 2024
2 checks passed
@ShreckYe ShreckYe deleted the kotlin-2.1.0-and-above branch December 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant