Skip to content

Commit

Permalink
Remove the kotlin-jvm-*-app-conventions script plugins as they are …
Browse files Browse the repository at this point in the history
…unnecessary as it turns out, and the `implementation(platform(kotlin("bom")))` line without a Kotlin version has introduced a "Could not parse POM" build error in projects dependent on a project with one of these plugins applied via Maven since Kotlin 2.0.20

See commit 1648b7e and commit dc9d1c8 for more details.
  • Loading branch information
ShreckYe committed Dec 2, 2024
1 parent 9b54ad2 commit a490666
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 69 deletions.
14 changes: 1 addition & 13 deletions architecture-common-gradle-plugins/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,7 @@ gradlePlugin {
fun scriptConventionsPlugin(idSuffix: String, displayName: String, description: String = displayName) =
scriptPlugin(`package`, idSuffix, displayName, description)

scriptConventionsPlugin(
"kotlin-jvm-common-app-conventions",
"Kotlin/JVM common app conventions"
)
scriptConventionsPlugin(
"kotlin-jvm-application-app-conventions",
"Kotlin/JVM application app conventions"
)
scriptConventionsPlugin(
"kotlin-jvm-library-app-conventions",
"Kotlin/JVM library app conventions"
)

// TODO consider removing these too
scriptConventionsPlugin(
"kotlin-multiplatform-app-conventions",
"Kotlin Multiplatform app conventions"
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/VersionsAndDependencies.kt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ object DependencyVersions {
val binaryCompatibilityValidator = "0.16.3"
}

val alignedPluginVersion = "0.7.1-kotlin-2.1.0-SNAPSHOT"
val alignedPluginVersion = "0.8.0-kotlin-2.1.0-SNAPSHOT"

// "x.y.z" indicates the version of the way of organizing the code,
// and the date indicates the version when the dependency versions are updated.
Expand Down

0 comments on commit a490666

Please sign in to comment.